Generate the ssh key using the cryptography module #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better because ssh-keygen is not available on all platforms (such as Windows). This changes the Python API a bit: - generate_ssh_key now returns the private and public ssh keys, and does not write to a file. - encrypt_file has been removed and replaced with encrypt_to_file, which encrypts contents and writes them to a file. Fixes #301.
asmeurer
force-pushed
the
cryptography-ssh-keygen
branch
from
e59e614
to
9cfa099
Compare
It was not being used by the cryptography generation. I could probably still add it in, but as far as I can tell, the note is not visible from GitHub anyway (and the public ssh key is not used anywhere else). GitHub shows its own note, which is set by the title parameter of upload_GitHub_deploy_key().
asmeurer
force-pushed
the
cryptography-ssh-keygen
branch
from
9cfa099
to
ba7317a
Compare
|
So it works I guess. I hope I didn't f up the crypto. Another benefit of this is that the private SSH key is never written to the filesystem. |
|
Hey @asmeurer -- this looks good to me. Always nice to be more platform friendly and to keep sensitive data off the filesystem. This can go in after travis finishes up. |
|
Yeah, I looked over the |
|
Thanks for the review @gforsyth! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better because ssh-keygen is not available on all platforms (such as
Windows).
This changes the Python API a bit:
generate_ssh_key now returns the private and public ssh keys, and does not
write to a file.
encrypt_file has been removed and replaced with encrypt_to_file, which
encrypts contents and writes them to a file.
Fixes #301.