test: add comprehensive unit tests for credential, hash, user, and trust extraction logic#223
Merged
Merged
Conversation
…ility functions **Added:** - Added tests for deduplication and sanitization logic, including ANSI stripping and domain normalization in `dedup/tests.rs` - Added tests for hash extraction, deduplication, and cracked password parsing in `output_extraction/hashes.rs` - Added unit tests for credential validation, ANSI stripping, extraction functions, and empty extraction handling in `output_extraction/mod.rs` - Added tests for user extraction and validation, including machine account and format checks in `output_extraction/users.rs` - Added tests for number formatting, duration formatting, and string truncation utilities in `util.rs` - Added tests for domain controller detection and trust relationship logic in `models/core.rs` - Added test for `ParseDelegationTypeError` display implementation in `parsing/types.rs`
**Added:** - Integrate cargo-llvm-cov for Rust code coverage in CI workflow - Upload coverage reports to Codecov using codecov-action in rust.yaml - Add Codecov status badge to README.md **Changed:** - Replace cargo test step with cargo llvm-cov to generate coverage data in rust.yaml
**Added:** - Added tests for blue token usage key format, model cost lookup, model field parsing, and usage cost estimation in `ares-core/src/token_usage.rs` - Added tests for username-as-password credential filtering, adidnsdump parsing, trusted domain deduplication, and host service merging in `ares-tools/src/parsers/mod.rs` - Added tests for outbound trust parsing, unknown direction handling, trust type inference based on domain length, and domain normalization in `ares-tools/src/parsers/trust.rs`
dreadnode-renovate-bot
Bot
added
area/docs
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
ares-cli/src/dedup/tests.rsares-cli/src/orchestrator/output_extraction/hashes.rsares-cli/src/orchestrator/output_extraction/mod.rsares-cli/src/orchestrator/output_extraction/users.rsares-cli/src/util.rsares-core/src/models/core.rsares-core/src/parsing/types.rsares-core/src/token_usage.rsares-tools/src/parsers/mod.rsares-tools/src/parsers/trust.rsChanged:
.github/workflows/rust.yamlREADME.md