feat: add rpcclient as required tool and clarify pass-the-hash handling#237
Merged
Conversation
…dling **Added:** - Added `samba-common-bin` to lateral_movement_tools and recon_tools package lists to provide `rpcclient` for SMB/RPC operations - Included `smbclient` as a required package for share enumeration in recon_tools **Changed:** - Updated tool_check test to expect `rpcclient` and `smbclient` instead of `pth-winexe` - Expanded SMB tool category in tools.yaml to include both `smbclient` and `rpcclient` - Documented the removal of pass-the-hash binaries for Debian trixie in tools.yaml and left only function names to avoid false missing tool checks **Removed:** - Removed pass-the-hash binaries from tools.yaml due to unavailability on Debian trixie, retaining only function names for registry completeness
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 383 383
Lines 80224 80225 +1
=======================================
+ Hits 60085 60086 +1
Misses 20139 20139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… files **Changed:** - Updated package tables in `lateral_movement_tools` role README to add `samba-common-bin` before `sshpass` and shift `sshpass` and `proxychains4` indices for both Kali and Ubuntu package lists - Added `smbclient` to `recon_tools` role README package tables for both Kali and Ubuntu, updating list indices accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
rpcclientas a required tool for SMB/RPC lateral movement and recon rolessamba-common-binandsmbclientwhere neededrpcclientandsmbclientin the tool check suiteAdded:
rpcclientadded as a required binary for SMB operations in the tool registry and test suitesamba-common-bin(which providesrpcclient) added to package lists for lateral movement and recon roles on both Kali and UbuntuChanged:
smbclientandrpcclientbinaries intools.yamlsmbclientandsamba-common-binare installed for complete SMB/RPC supportsmbclientandrpcclientin the tool check for lateral movement toolsRemoved: