fix: improve acl vuln routing and certipy_shadow hash handling#283
Merged
Merged
Conversation
…fallback **Added:** - Added tests to verify that an empty-string `hashes` is treated as missing, ensuring the password fallback logic works correctly in `certipy_shadow` **Changed:** - Updated `certipy_shadow` to filter out empty-string `hashes` values so that Certipy does not receive invalid empty hash arguments and the password branch executes as expected - Clarified documentation and schema for `password` and `hashes` fields in the tool definition, specifying that exactly one must be provided and empty strings must be omitted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
aclworker instead of defaulting toprivesccertipy_shadowtool to ignore empty-string hashes, preventing failurescertipy_shadowinput handlingAdded:
is_acl_style_vuln_typefunction intask_builders.rsto identify and route ACL-based vulnerabilities to the appropriate workertask_builders.rscertipy_shadowhash handling - Verified that empty-string hashes are ignored and password fallback works inadcs.rsChanged:
Dispatcher::submit_exploit_taskto use the new ACL detection and route vulnerabilities with ACL primitives to theaclworker whenrecommended_agentis emptycertipy_shadowargument handling - Modifiedadcs.rsto treat empty-stringhashesas missing, ensuring Certipy does not receive invalid hash arguments and the password fallback is used correctlycertipy_shadowin the tool registry to prevent misuse ofpasswordandhashesfieldsRemoved:
recommended_agentexploits to theprivescworker, which led to toolset mismatches for ACL-based vulnerabilities