fix: improve acl exploit routing and certipy_shadow hash handling#284
Merged
Merged
Conversation
**Added:** - Added `is_acl_style_vuln_type` function to identify ACL-related vulnerability types and route them to the appropriate worker - Added tests for `is_acl_style_vuln_type` to ensure correct matching of both bare and prefixed forms, as well as rejection of non-ACL types **Changed:** - Updated exploit task submission logic to use `acl` worker for ACL-style vulnerabilities when `recommended_agent` is empty, improving toolchain compatibility and reducing failed exploit attempts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/more-attack-cov #284 +/- ##
=======================================================
Coverage ? 76.35%
=======================================================
Files ? 432
Lines ? 113169
Branches ? 0
=======================================================
Hits ? 86407
Misses ? 26762
Partials ? 0
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
is_acl_style_vuln_typehelper to match both bare and prefixed forms of ACL exploitation primitives intask_builders.rstask_builders.rsadcs.rsChanged:
is_acl_style_vuln_typeto select the correct worker (aclvsprivesc) based on the vulnerability type whenrecommended_agentis empty, ensuring ACL primitives are handled by the right agentpasswordorhashesshould be provided, and that empty strings must be omitted, in both the tool description and field descriptions inadcs.rshashesas missing, ensuring the password fallback triggers and preventing invalid empty values from being passed to certipy inadcs.rsRemoved:
privescdefault for exploit tasks intask_builders.rs; now dynamically chooses betweenaclandprivescbased on vuln type