refactor: extract gMSA exploit token emission logic into standalone helper#292
Merged
Merged
Conversation
**Added:** - Introduced `emit_gmsa_exploit_token_if_gmsa` async helper to encapsulate gMSA exploit token side-effect logic and ensure consistent credit emission for gMSA hashes captured via secretsdump - Added comprehensive tests for `emit_gmsa_exploit_token_if_gmsa`, covering gMSA, machine accounts, regular users, and case normalization **Changed:** - Replaced inline gMSA exploit token emission logic in `extract_discoveries` with a call to the new `emit_gmsa_exploit_token_if_gmsa` helper for improved code reuse and clarity
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/more-attack-cov #292 +/- ##
=======================================================
Coverage ? 76.21%
=======================================================
Files ? 433
Lines ? 114093
Branches ? 0
=======================================================
Hits ? 86954
Misses ? 27139
Partials ? 0
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
emit_gmsa_exploit_token_if_gmsaasync helper to emit exploit tokens for gMSA accounts incidentally captured via secretsdump or DCSyncChanged:
extract_discoveriesnow delegates gMSA side-effect to the new helper function, improving modularity and separation of concernsRemoved: