Skip to content

fix: correct domain assignment for text-extracted credentials#316

Merged
l50 merged 1 commit into
mainfrom
fix/text-cred-domain-from-state-users
May 14, 2026
Merged

fix: correct domain assignment for text-extracted credentials#316
l50 merged 1 commit into
mainfrom
fix/text-cred-domain-from-state-users

Conversation

@l50
Copy link
Copy Markdown
Contributor

@l50 l50 commented May 14, 2026

Key Changes:

  • Fixed misattribution of domains for text-extracted credentials by preferring directory-attested domains
  • Introduced reconciliation logic to resolve domain ambiguities based on trusted enumeration data
  • Enhanced logging to warn when a credential's domain is reassigned
  • Added comprehensive tests covering domain reconciliation scenarios

Added:

  • Domain reconciliation logic for credentials - Implemented reconcile_extracted_credential_domain to prefer directory-attested domains when the username is uniquely identified in state.users
  • Unit tests for domain reconciliation - Added a dedicated test module with coverage for unique, ambiguous, and case-insensitive username/domain scenarios in tests.rs

Changed:

  • Credential processing pipeline - Updated extraction logic to apply domain reconciliation before storing credentials, ensuring downstream authentication attempts use the correct domain
  • Logging for domain reassignment - Added warning logs when a credential's domain is reassigned to inform users of corrections during processing

… accuracy

**Added:**

- Implement domain reconciliation for text-extracted credentials, preferring directory-attested domains from state.users when a unique match is found
- Add unit tests covering domain correction logic for various edge cases

**Changed:**

- Update credential ingestion to apply domain reconciliation before processing extracted credentials, logging corrections when applied
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 89.47368% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.76%. Comparing base (95f48cb) to head (308b5b6).

Files with missing lines Patch % Lines
ares-cli/src/orchestrator/result_processing/mod.rs 71.42% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         439      439           
  Lines      124138   124213   +75     
=======================================
+ Hits        97773    97840   +67     
- Misses      26365    26373    +8     
Files with missing lines Coverage Δ
...es-cli/src/orchestrator/result_processing/tests.rs 100.00% <100.00%> (ø)
ares-cli/src/orchestrator/result_processing/mod.rs 26.77% <71.42%> (+1.35%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@l50 l50 merged commit b147f59 into main May 14, 2026
12 checks passed
@l50 l50 deleted the fix/text-cred-domain-from-state-users branch May 14, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant