fix: correct domain assignment for text-extracted credentials#316
Merged
Conversation
… accuracy **Added:** - Implement domain reconciliation for text-extracted credentials, preferring directory-attested domains from state.users when a unique match is found - Add unit tests covering domain correction logic for various edge cases **Changed:** - Update credential ingestion to apply domain reconciliation before processing extracted credentials, logging corrections when applied
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 78.76% 78.76%
=======================================
Files 439 439
Lines 124138 124213 +75
=======================================
+ Hits 97773 97840 +67
- Misses 26365 26373 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
reconcile_extracted_credential_domainto prefer directory-attested domains when the username is uniquely identified instate.userstests.rsChanged: