fix: normalize ntlm hash output for compatibility with external parsers#319
Merged
Conversation
**Added:** - Added `report_hash_value` function to output only bare NT hash for NTLM `LM:NT` pairs, ensuring compatibility with external scoreboards expecting strict 32-hex NT hashes - Added tests for `report_hash_value` to cover NTLM pairs, bare NT, Kerberos blobs, and non-NTLM hashes **Changed:** - Updated loot JSON output to use `report_hash_value` for NTLM hashes, stripping LM part when appropriate
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage 78.81% 78.81%
=======================================
Files 439 439
Lines 124461 124494 +33
=======================================
+ Hits 98092 98124 +32
- Misses 26369 26370 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
report_hash_valuefunction to handle hash output normalization logicAdded:
report_hash_valueto strip LM portion from NTLMLM:NTpairs and return only the NT hash for JSON outputreport_filter.rsChanged:
print_loot_jsonto use the newreport_hash_valuefunction when serializinghash_valuefields, ensuring only the NT portion is reported for NTLM hashesRemoved:
report_filter.rs