style: remove redundant comments and clarify phase labels in automation and tooling#321
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 78.78% 78.78%
=======================================
Files 439 439
Lines 124638 124692 +54
=======================================
+ Hits 98190 98237 +47
- Misses 26448 26455 +7
🚀 New features to boost your workflow:
|
… consistency **Changed:** - Removed redundant or obvious step and phase comments across multiple modules to improve readability without affecting code functionality - Standardized step and phase output labels in coercion and privilege escalation flows to use consistent, concise terminology (e.g., "Phase 1: unauth PetitPotam" → "unauth PetitPotam", "Step 1: Template Modification" → "Template Modification") - Updated test constants to match new output labels for phases and steps - Clarified and shortened instructional output in ADCS exploitation instructions for ESC3 - Minor adjustments to comments for clarity and brevity in trust exploitation routines - Improved comment clarity regarding optional and required steps, especially where helper scripts are invoked or output filenames must match
…iles **Changed:** - Removed commented section headers in `normalize_source_label` for cleaner code in `ares-cli/src/dedup/labels.rs` - Removed commented test section headers for improved readability in `ares-cli/src/orchestrator/automation/stall_detection.rs`
…S chains **Added:** - Introduced `render_chain_output` helper to format chained tool output with labeled headers - Added unit tests for `render_chain_output` covering concatenation, empty steps, order, and edge cases **Changed:** - Updated certipy ADCS chain functions to use `render_chain_output` for consistent output formatting - Simplified chain output construction by replacing repeated formatting code with the new helper
**Changed:** - Reformatted lines in test functions to reduce line breaks and improve readability in `laps.rs` and `domains.rs` by combining function arguments onto single lines where appropriate
0217caa to
09f96b1
Compare
**Changed:** - Changed S3_BUCKET assignment to use export, ensuring visibility to subprocesses in test.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Changed:
dedup/labels.rs,orchestrator/automation/adcs_exploitation.rs,orchestrator/automation/stall_detection.rs,orchestrator/state/publishing/credentials.rs,nats.rs, andprivesc/trust.rsares-tools/src/coercion.rsand related test code to use concise, consistent labels (e.g., "=== unauth PetitPotam ===" instead of "=== Phase 1: unauth PetitPotam ===")certipy_esc3_full_chain,certipy_esc4_full_chain,certipy_esc1_full_chain) for clarity and alignment with updated phase namingRemoved: