From 662b4e0b843d2f399257f689d51c065f232f44b6 Mon Sep 17 00:00:00 2001 From: "Gpound.liu" <141617023+Gggpound@users.noreply.github.com> Date: Sat, 30 Mar 2024 14:48:38 +0800 Subject: [PATCH] fix(sheet): error while creating an empty subunit (#1748) --- .../src/services/conditional-formatting.service.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/sheets-conditional-formatting/src/services/conditional-formatting.service.ts b/packages/sheets-conditional-formatting/src/services/conditional-formatting.service.ts index 50c8c9cc82..0bf7bbcaf2 100644 --- a/packages/sheets-conditional-formatting/src/services/conditional-formatting.service.ts +++ b/packages/sheets-conditional-formatting/src/services/conditional-formatting.service.ts @@ -40,7 +40,7 @@ type ComputeStatus = 'computing' | 'end' | 'error'; interface IComputeCache { status: ComputeStatus }; const beforeUpdateRuleResult = createInterceptorKey< { subUnitId: string; unitId: string; cfId: string }>('conditional-formatting-before-update-rule-result'); -@OnLifecycle(LifecycleStages.Starting, ConditionalFormattingService) +@OnLifecycle(LifecycleStages.Ready, ConditionalFormattingService) export class ConditionalFormattingService extends Disposable { // >> private _ruleCacheMap: Map>> = new Map(); @@ -162,8 +162,8 @@ export class ConditionalFormattingService extends Disposable { }) ) ); - const workbook = this._univerInstanceService.getCurrentUniverSheetInstance(); - handleWorkbookAdd(workbook); + const workbookList = this._univerInstanceService.getAllUniverSheetsInstance(); + workbookList.forEach((workbook) => handleWorkbookAdd(workbook)); } private _initSheetChange() {