Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log transformation: + scale_y_log10() #24

Open
installingrattle opened this issue Oct 6, 2018 · 3 comments
Open

log transformation: + scale_y_log10() #24

installingrattle opened this issue Oct 6, 2018 · 3 comments
Labels

Comments

@installingrattle
Copy link

@installingrattle installingrattle commented Oct 6, 2018

Thank you for an incredible package.

Any chance we can get

+scale_y_log10()
+scale_x_log10()

as options? Thank you

@pvictor pvictor added the enhancement label Oct 6, 2018
@itcarroll
Copy link
Contributor

@itcarroll itcarroll commented Oct 10, 2018

Began implementing this feature on itcarroll/esquisse.

screen shot 2018-10-09 at 10 05 47 pm

I pulled all the *_trans from the "scales" package to populate a new selectInput for X and Y in module-chartControls.R. This may be a bit much, and allows transformations that break the plot (but don't crash the app). The "right way" might be to include a possible_trans analagous to possible_geoms ... which might be a lot of work. Thoughts?

@dan-reznik
Copy link

@dan-reznik dan-reznik commented Apr 18, 2019

is it useable? should i install it?

@itcarroll
Copy link
Contributor

@itcarroll itcarroll commented Apr 24, 2019

@dan-reznik Sure, the fork is working as described. I moved it though, so install with devtools::install_github('sesync-ci/esquisse@semilog').

Was hoping for feedback on the "right way" before creating a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.