Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Data manipulation #79

Closed
daricomp opened this issue Oct 23, 2019 · 2 comments
Closed

Suggestion: Data manipulation #79

daricomp opened this issue Oct 23, 2019 · 2 comments

Comments

@daricomp
Copy link

@daricomp daricomp commented Oct 23, 2019

The actual implementation saves in the same objet the data manipulation realized with dplyr, while it would be better not to.
It also creates two code blocks, when it would be better to have only one.
Example follows.

Actual:

diamonds <- diamonds %>%
filter(carat < 4)

ggplot(diamonds) +
aes(x = carat) +
geom_histogram()

Suggestion:

diamonds %>%
filter (carat < 4) %>%
ggplot () +
aes(x = carat) +
geom_histogram()

@GegznaV
Copy link

@GegznaV GegznaV commented Oct 28, 2019

I agree that a plotting tool should not modify original data and %>% syntax would be a better choice.

@pvictor
Copy link
Member

@pvictor pvictor commented Jan 8, 2020

Makes sense, implemented in 0.2.3.

Thanks,

Victor

@pvictor pvictor closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.