Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facets with facet_wrap #30

Merged
merged 1 commit into from Oct 10, 2018
Merged

Facets with facet_wrap #30

merged 1 commit into from Oct 10, 2018

Conversation

@itcarroll
Copy link
Contributor

@itcarroll itcarroll commented Oct 10, 2018

Contribution discussed in feature request #6.

The implementation uses p + facet_wrap(facet), where p is a ggplot object and facet is a string matching a variable name. If the "Facet" box could be updated to accept 2 variables, I believe you would get a grid where the order determines row vs. columns.

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 10, 2018

Codecov Report

Merging #30 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   50.91%   50.84%   -0.08%     
==========================================
  Files          18       18              
  Lines        2011     2018       +7     
==========================================
+ Hits         1024     1026       +2     
- Misses        987      992       +5
Impacted Files Coverage Δ
R/esquisserServer.R 0% <0%> (ø) ⬆️
R/ggplot_helpers.R 75.6% <100%> (+0.24%) ⬆️
R/esquisserUI.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1645050...0b3a782. Read the comment docs.

@pvictor pvictor merged commit 08ba95c into dreamRs:master Oct 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pvictor
Copy link
Member

@pvictor pvictor commented Oct 10, 2018

Thanks Ian! I updated DESCRIPTION and NEWS to add your contribution.

@itcarroll itcarroll deleted the SESYNC-ci:facet branch Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.