Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to Express 3.0 #3

Closed
trevex opened this issue Oct 25, 2012 · 5 comments
Closed

Migrating to Express 3.0 #3

trevex opened this issue Oct 25, 2012 · 5 comments

Comments

@trevex
Copy link

trevex commented Oct 25, 2012

Really like your lightweight templating engine and would like to use it along with express 3.0 as well:

Express 2x template engine compatibility required the following module export:

 exports.compile = function(templateString, options) {
   return a Function;
 };

Express 3x template engines should export the following:

 exports.__express = function(filename, options, callback) {
   callback(err, string);
 };
@ben-lin
Copy link
Member

ben-lin commented Oct 25, 2012

Thanks for the feedback :) I'll try to add support for express 3.0 ( and maybe for the missing layout & partial as well ) this weekend.

@seandunaway
Copy link

+1 :)

@asilvas
Copy link

asilvas commented Jul 5, 2013

Status? I've evaluated dozens of the most popular template renderers, and have to say thunder is one of, if not, the fastest and most robust overall. Kudos.

@ben-lin
Copy link
Member

ben-lin commented Jul 6, 2013

Sorry guys I've been super busy with my daily work and we are still using express 2.x for now. I'll see if I can do something this weekend.

@ben-lin
Copy link
Member

ben-lin commented Dec 12, 2013

Sorry it took so long. Please use express-thunder as an adaptor for express3+. ( layout, partial included )

@ben-lin ben-lin closed this as completed Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants