Permalink
Browse files

Let AssertionErrors bubble up

Sometimes we want to use AssertionError to cause test
failures, and it is unlikely to be used in real code,
so just let the error bubble up if it is encountered
while loading a plugin.

Change-Id: I7ad20b0796c1a02427d324aa7f35bb238013c425
Signed-off-by: Doug Hellmann <doug.hellmann@dreamhost.com>
  • Loading branch information...
1 parent 0a51bfd commit c89446fbdc10198fb8e3ae86f44c92ef3dba8e00 @dhellmann dhellmann committed Jan 5, 2013
Showing with 6 additions and 1 deletion.
  1. +5 −0 docs/source/history.rst
  2. +1 −1 stevedore/extension.py
View
5 docs/source/history.rst
@@ -2,6 +2,11 @@
History
=========
+dev
+
+ - Ignore AssertionError exceptions generated when plugins are
+ loaded.
+
0.7.2
- Fix logging support for Python 2.6.
View
2 stevedore/extension.py
@@ -76,7 +76,7 @@ def _load_plugins(self, invoke_on_load, invoke_args, invoke_kwds):
)
if ext:
extensions.append(ext)
- except KeyboardInterrupt:
+ except (KeyboardInterrupt, AssertionError):
raise
except Exception as err:
LOG.error('Could not load %r: %s', ep.name, err)

0 comments on commit c89446f

Please sign in to comment.