Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when width/height units are mismatched, embed height is not correct #1112

Closed
afuna opened this issue Jan 6, 2015 · 1 comment · Fixed by #1114
Closed

when width/height units are mismatched, embed height is not correct #1112

afuna opened this issue Jan 6, 2015 · 1 comment · Fixed by #1114
Assignees
@afuna
Labels
status: claimed status: untriaged

Comments

@afuna
Copy link
Member

afuna commented Jan 6, 2015

Discovered in #1102
afuna added a commit to afuna/dw-free that referenced this issue Jan 6, 2015
@afuna
[dreamwidth#1112] Use pixel measurement for ratio when width/height u…
51f1282 
…nit mismatch

Fixes dreamwidth#1112.
@afuna
Copy link
Member Author

afuna commented Jan 6, 2015

This fixes the specific imgur issue, but I am trying to decide if there's a way to do this that still uses percentages. (especially if width is specified in px and height in %, though I think that's rather much less likely)

@afuna afuna mentioned this issue Jan 6, 2015
Merged
@afuna afuna mentioned this issue Jan 17, 2015
Merged
afuna added a commit that referenced this issue Jan 17, 2015
@afuna
Merge pull request #1114 from afuna/embed-different-units-bug-1112
499d4fa 
[#1112] Use pixel measurement for ratio when width/height unit mismatch
afuna added a commit to afuna/dw-free that referenced this issue Jan 18, 2015
@afuna
[dreamwidth#1112] Re-enable placeholders for videos in https pages
aaee5bc 
Turns out it wasn't broken specifically for https pages. There was a
wider problem fixed in dreamwidth#1103, but http pages were working (because
cached).

So basically this is a revert for a fix to a nonexistent problem...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afuna afuna

Labels
status: claimed status: untriaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1112] Use pixel measurement for ratio when width/height unit mismatch afuna/dw-free
2 participants
@afuna @robodw-issues