Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the old form of the icon url recognized by the contextualhover #1490

Merged
merged 1 commit into from Jul 15, 2015

Conversation

afuna
Copy link
Member

@afuna afuna commented Jul 14, 2015

We should only recognize the old dreamwidth url, not one for any other
site

We should only recognize the old dreamwidth url, not one for any other
site
@afuna
Copy link
Member Author

afuna commented Jul 14, 2015

This could conceivably be made generic by using Site.siteroot -- but:

a) JS doesn't allow you to ignore special characters. You'd have to write a regexp to convert those periods into back-slashed periods. Meh

b) Site.siteroot includes http which brings us to http versus https

c) This is pretty much an edge case handilng site-specific user behavio

@rahaeli
Copy link
Contributor

rahaeli commented Jul 15, 2015 via email

kareila added a commit that referenced this pull request Jul 15, 2015
Limit the old form of the icon url recognized by the contextualhover

Fixes #1481.
@kareila kareila merged commit 7c54893 into dreamwidth:develop Jul 15, 2015
@kareila
Copy link
Member

kareila commented Jul 15, 2015

Works for me! Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants