The third parameter to error functions has changed from a simple string
to an instance of *Error object.
This fixes the test after updating to the latest libraries, but before
we make any changes to our JS files
- The throbber will now always be placed after, never before.
- Changed the implementation to use a background image instead of
appending an image, to keep the text from potentially bobbing up and
- use $.throbber from dw-core.js, instead of having multiple different
implementations of handling the image
This case covers error messages which behave like so:
- if you click and quickly receive an error (while you're still over the
trigger), then the error message fades away when you move your mouse
away (or lose keyboard focus)
- if you clicked then moved away, maybe doing something else on the
page, then the error message doesn't fade away to give you a chance to
- the error message will fade away if you interact with the trigger
- the error message will fade away if you interact with the tooltip
- in both cases, interaction can mean either a hover/leave, or
keyboard interaction (if there's something focusable in the
- instead of using a tooltip for a dynamic form (what was I
thinking???), use a dialog. Immediate plusses are that we don't have
to worry about keeping the tooltip persistent. May also help with
screen reader accessibility because the role is now more semantically
correct (dialog). Also keyboard accessibility...
- various tweaks in commentmanage
- use self.error instead of trying to use the content option's callback
- include new files. Limit scope of iconselector CSS so it doesn't
affect other dialog boxes
- fix tests
Also fixes the issue where the comment icon didn't update when
tracking a thread.
It was broken because we passed in the LJ_cmtinfo variable when creating
widgets (so we could access the cmtinfo as a local variable for slight
efficiency purposes). Problem was that the LJ_cmtinfo variable is
initialized after we create the widgets. So now we just use the global
variable, which isn't ideal but will do.
Old method just plain didn't try to error-check if we said that the
ajaxtip should try to handle multiple simultaneous requests. Now we
handle it on a per-batch basis.
- Remove explicit option; instead handle it based on whether the options
to be loaded is an object or an array of objects
- If we call load again on the same widget for a new batch of requests,
we abort the old one and start again with the new
- Change the tracking widget to use the new API. Tracking widget needs
it because each checkbox is a separate AJAX request.
The contextual hover menu
- when you hover over the trigger a short period of time
- NOT if you merely pass the mouse over the trigger
- as long as the mouse is over the trigger
- if you move the mouse from the trigger to the contextual popup
- as long as the mouse is over the tooltip
- NOT if you move the mouse away from the trigger before the
popup is fully visible
- when you move the mouse over then out of the contextual popup
- a short time after you move the mouse out of the trigger
(only if you don't then move it to the popup)
Prevents the contextualhover trigger (user icon, userhead) from
wriggling when you mouse over them
Instead of the throbber, add "Loading..." text to indicate we're doing something
So that the popup with data doesn't just appear with no warning.
Not doing the standard throbber appear/disappear, because it was
wiggling icons / links out of place on hover (somewhat disturbingly so).
We might want to show the image instead of text (obv with alt text), but
let's start with text.
- Reduce gloss on buttons / headers a tiny bit for increased contrast
- Change the pillowy gradient on dialog boxes, which doesn't fit any of
the other elements on our site, to a flatter texture
- Reduce widgets font size from 1.1em to 1em -- that is, make the
widgets the same size as the text on the rest of the page (which we
keep at a reasonable size already), not startlingly larger
.attr() is supposedly now for initial state, .prop() for current state.
Looks like jQuery has some backwards compatibility for this case. Don't
*need* to update, but updating anyway before one of the nuances comes
back to bite us.
This also means that we have made setting / checking the trueness of
diasbled/checked is more consistent throughout.