Fix #1599 consistency when joining moderated-membership comm #1803
Conversation
Contextual hover now shows accept instead of join if you have a pending invitation.
| if (data.is_member) { | ||
| membershipLink.href = data.url_leavecomm; | ||
| membershipLink.innerHTML = "Leave"; | ||
| var membership_action = "leave" |
There was a problem hiding this comment.
I do see one possible issue here, which is that you've moved the variable scope of membership_action (the "var" declaration) into the conditional, which may mean (if the rules for JS are the same as for Perl) that the assignment is lost outside of that conditional. I would keep the scope declaration above:
var membership_action;
And then assign to the variable in each conditional without the var qualifier:
membership_action = "leave"
membership_action = "accept"
membership_action = "join"
|
|
||
| if (!data.is_closed_membership || data.is_member) { | ||
| var membershipLink = document.createElement("a"); | ||
|
|
||
| var membership_action = data.is_member ? "leave" : "join"; |
There was a problem hiding this comment.
Let's put the var membership_action statement back here where it was previously, just to keep the scope the same.
|
I did discover one edge case when testing this: if you accept the invitation, then click again to leave the community, it goes back to "Accept Invitation" instead of "Join Community", and if you click a third time, nothing happens. Not sure if it's worth the effort to correct, since it's not likely that someone will want to do that on purpose, but it might get double-clicked accidentally. |
Contextual hover now shows accept instead of join if you have
a pending invitation. See #1599 for details.