Damien Regad dregad

  • Switzerland
  • Joined on

Organizations

@mantisbt @mantisbt-plugins
dregad commented on pull request ADOdb/ADOdb#108
@dregad

May I kindly ask you to rebase your feature branch on top of latest master, so that the pull request only contains relevant commits

dregad commented on pull request ADOdb/ADOdb#107
@dregad

May I kindly ask you to rebase your feature branch on top of latest master, so that the pull request only contains relevant commits

dregad commented on pull request ADOdb/ADOdb#106
@dregad

May I kindly ask you to rebase your feature branch on top of latest master, so that the pull request only contains relevant commits.

dregad commented on issue ADOdb/ADOdb#105
@dregad

Issue #88 introduced this regression, and I don't think this should be closed without patching the code. @ipso if you could please review your cod…

dregad reopened issue ADOdb/ADOdb#105
@dregad
ExecuteCursor produce error: oci_execute() expects parameter 1 to be resource, string given
dregad commented on pull request mantisbt/mantisbt#605
@dregad

Not sure what you did with the pull request here, but I suggest you rebase the branch again on top of latest master and push it again.

dregad closed pull request ADOdb/ADOdb#102
@dregad
Fix for bug #41 (mssqlnative / insert_ID() fails if server returns more than 1 row)
dregad commented on issue ADOdb/ADOdb#55
@dregad

Closing this since you did not provide any feedback.

dregad closed issue ADOdb/ADOdb#55
@dregad
Needless output in ADODB_mssqlnative with activated debugging
dregad commented on pull request ADOdb/ADOdb#102
@dregad

Thanks for your contribution

dregad pushed to master at ADOdb/ADOdb
@dregad
  • @gitjti f170923
    mssqlnative: fix insert_ID() fails if server returns more than 1 row
dregad closed issue ADOdb/ADOdb#41
@dregad
mssqlnative / insert_ID() fails if server returns more than 1 row
dregad commented on pull request ADOdb/ADOdb#103
@dregad

Many thanks for your contribution.

dregad pushed to master at ADOdb/ADOdb
@dregad
  • @MorrisR2 c0b38df
    mssqlnative: use correct setting 'WarningsReturnAsErrors'
dregad closed pull request ADOdb/ADOdb#103
@dregad
mssqlnative: sqlsrv_configure(warnings_return_as_errors should be War…
@dregad

In short: fork the repo, create a branch for your fix, write and test your patch, push the branch with your commits to your github fork and submit …

@dregad

Please open open distinct issues for each individual problem. You're also welcome to submit code contributions via pull request to fix those.

dregad deleted branch legend at dregad/mantisbt
@dregad
dregad merged pull request mantisbt/mantisbt#607
@dregad
Status legend fixes
6 commits with 90 additions and 82 deletions
@dregad
dregad commented on pull request mantisbt/mantisbt#607
@dregad

Added commits taking your comments into consideration. Let me know your feedback, esp. @vboctor regarding the API change.

@dregad
dregad commented on pull request mantisbt/mantisbt#607
@dregad

Good point about moving the logic to the API. But in that case, what about an alternative approach: adding a new "target location" parameter (i.e. …

@dregad
dregad opened pull request mantisbt/mantisbt#607
@dregad
Status legend fixes
2 commits with 42 additions and 36 deletions
dregad created branch legend at dregad/mantisbt
dregad commented on pull request mantisbt/mantisbt#606
@dregad

Thanks for reviewing this @vboctor that was on my todo list but I had not gotten around to it yet. I don't think there's anything to add ;-)

dregad commented on pull request mantisbt/mantisbt#605
@dregad

For the record: I'm not saying this shouldn't be done, I just want to make sure we're not introducing any regressions.

dregad commented on pull request mantisbt/mantisbt#605
@dregad

Are we sure that this really has no side effects ? Are all of the cases indeed covered by $document.ready() ? I'm concerned about the jscalendar (w…