Skip to content

Refactor IAS zone enrollment and further device integration #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 22, 2020

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented May 12, 2020

According to Zigbee spec (07-5123-06-zigbee-cluster-library-specification.pdf, 8.2.2.2.3 Implementation Guidelines), writing the IAS CIE address is mandatory to be done first in the enrollment process. Apparently, not much end devices seem to adhere to that, as an enrollment request is fired very early from those devices.
However, some devices (e.g. Sercomm siren) stick to the specs and require the CIE write before, otherwise they do not earn status enrolled. The refactor should be more robust adhering to the procedure and also consider "orphan" sensors (a device with an IAS sensors gets reset, in those cases, the sensor is already available).
Tested with Sercomm siren, Heiman and Develco smoke detector.

Copy link
Collaborator

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not going to work. Late night?

Use != instead of !modelId.

@SwoopX
Copy link
Collaborator Author

SwoopX commented May 12, 2020

You got no idea... 😞 Thanks for keeping an eye though.

@SwoopX SwoopX changed the title Further device integration Refactor IAS zone enrollment and further device integration May 15, 2020
@manup manup merged commit f4bd592 into dresden-elektronik:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants