-
Notifications
You must be signed in to change notification settings - Fork 518
Refactor IAS zone enrollment and further device integration #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebaauw
reviewed
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This not going to work. Late night?
Use !=
instead of !modelId
.
You got no idea... 😞 Thanks for keeping an eye though. |
Further additions for RGBgenie ZB-5001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Zigbee spec (07-5123-06-zigbee-cluster-library-specification.pdf, 8.2.2.2.3 Implementation Guidelines), writing the IAS CIE address is mandatory to be done first in the enrollment process. Apparently, not much end devices seem to adhere to that, as an enrollment request is fired very early from those devices.
However, some devices (e.g. Sercomm siren) stick to the specs and require the CIE write before, otherwise they do not earn status enrolled. The refactor should be more robust adhering to the procedure and also consider "orphan" sensors (a device with an IAS sensors gets reset, in those cases, the sensor is already available).
Tested with Sercomm siren, Heiman and Develco smoke detector.