Improvements for Danfoss Ally / Hive TRV#3171
Merged
manup merged 36 commits intodresden-elektronik:masterfrom Sep 10, 2020
Merged
Improvements for Danfoss Ally / Hive TRV#3171manup merged 36 commits intodresden-elektronik:masterfrom
manup merged 36 commits intodresden-elektronik:masterfrom
Conversation
…DB load" This reverts commit 7ea96ac.
… Rocker (lumi.switch.b1naus01)
- Sunricher button map is suited best for EcoDim switches - Improved group handling for those switches
Button map still needs to be corrected
manup
requested changes
Aug 27, 2020
Member
manup
left a comment
manup
left a comment
There was a problem hiding this comment.
Added some comments for missing arguments and unhandled parameters.
manup
reviewed
Sep 1, 2020
Member
manup
left a comment
manup
left a comment
There was a problem hiding this comment.
Just a small question about the QString::toHtmlEscaped() usage, otherwise it looks fine.
| } | ||
| else | ||
| { | ||
| rsp.list.append(errorToMap(ERR_ACTION_ERROR, QString("/sensors/%1/config/%2").arg(id).arg(pi.key()).toHtmlEscaped(), |
Member
There was a problem hiding this comment.
Out of curiosity why the .toHtmlEscaped()?
From the documentation:
Converts a plain text string to an HTML string with HTML metacharacters <, >, &, and " replaced by HTML entities.
The strings are in a JSON object anyway, the only reason for escaping I can think of would be quotes or the other meta characters within the string, which we don't have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.displayflipped(bool) for those 2 devices to change display orientation.config.locked(bool) for those 2 devices to set child lock.state.mountingmodeactive(bool) for those 2 devices to see if mounting mode is active.config.mountingmode(bool) for those 2 devices to set mounting mode.config.errorcode(string) for those 2 devices to obtain current error codes. Assumption is that value0A00inplies no error.config.displayflipped,config.lockedandconfig.mountingmode.handleDiagnosticsClusterIndicationto handle data indications from diagnostics cluster.handleThermostatUiConfigurationClusterIndicationto handle data indications from thermostat ui configuration cluster.