Tuya thermostat and switch improvements, Kwikset 914 smart lock #3457

Smanar · 2020-10-20T16:01:06Z

Remove my try to filter VENDOR_EMBER device, solve Tuya TS0012 switches #3424
Correction for Moes HY368 and Tuya TS0601 thermostat (30 degree bug), solve Moes HY368 (aka Tuya) TS0601 on 2.05.85 #3440
Add Tuya Essentials Premium thermostat Thermostat Essentials Premium (Tuya) #3381
Add Tuya BTH-002 thermostat Moes Tuya Thermostat BTH-002 #3304
Add Saswell SEA801-Zigbee TRV Saswell SEA801-Zigbee TRV #3109
Add Revolt NX-4911-675 thermostat Revolt NX-4911-675 Thermostat #3588
Re adding Tuya / Zemismart switches TS0041, TS0042, TS0043, TS0043, TS0044 removed by error from another PR [Device Support Request] Zemismart 3 Gang Remote Switch (2nd attempt) #3524
Correction for Tuya / Zemismart Zigbee Smart Curtain switch ZW-EC-01 that not support lift Zenismart ZigBee Smart Curtain Switch ZW-EC-01 #3438
Added calibation command for Tuya Smart Life ZigBee 3.0 Curtain Blind Switch Loratap Tuya Smart Life ZigBee 3.0 Curtain Blind Switch for Roller Shutter Electric motor #3134
Removing "Heiman" for manufacture name with VENDOR_EMBER code.
Starting to add schedule feature for Tuya device.

Not tuya stuff

Kwikset 914 ZigBee smart lock Kwikset 914 ZigBee smart lock #3152

Update

manup · 2020-11-08T13:06:09Z

The PR is a bit too large. For the upcoming stable version I'd like to merge only the fixes but not new supported devices.
Can you please create another PR with only the fixes based on current master branch and git cherry pick the related commits?

Mimiix · 2020-11-09T08:19:05Z

@manup I'd like to remind you: We agreed on having no changes in stable releases. Stable has to be 100% of latest beta + any small fixes that occurred since then(Xiaomi vib sensor for example).

Smanar · 2020-11-09T16:53:33Z

I m agree, PR are too "meshed" (can't make small fixes with it) and code is too "sensible", can wait for beta, I will correct conflict later.

Update code with last official version

manup · 2020-11-14T15:10:52Z

I've changed the PR title and description to be more specific about for which devices the changes are.

manup

I've added a few comments, note some do apply to multiple code locations which I didn't comment.

tuya.cpp

manup · 2020-11-14T17:47:30Z

tuya.cpp

+                    else if (data == 1) { mode = QLatin1String("auto"); } // back to "auto"
+                    else
+                    {
+                        DBG_Assert(data <= 0); // unsupported


DBG_Assert(data <= 1); // unsupported

rest_sensors.cpp

manup · 2020-11-15T11:46:44Z

tuya.cpp

+                    else if (data == 6) { preset = QLatin1String("complex"); }
+                    else
+                    {
+                        DBG_Assert(data <= 0); // unsupported


DBG_Assert(data <= 6); // unsupported

manup · 2020-11-15T11:48:37Z

tuya.cpp

+                    else if (dp == 0x0403) { preset = QLatin1String("program"); }
+                    else
+                    {
+                        DBG_Assert(data <= 0); // unsupported


DBG_Assert(data == 0x0402 || data == 0x0403); // unsupported

tuya.cpp

manup · 2020-11-15T11:50:38Z

tuya.cpp

+                    else if (data == 1) { mode = QLatin1String("manu"); }
+                    else
+                    {
+                        DBG_Assert(data <= 0); // unsupported


DBG_Assert(data <= 1); // unsupported

manup · 2020-11-15T11:51:31Z

tuya.cpp

+                    else if (data == 1) { mode = QLatin1String("heat"); }
+                    else
+                    {
+                        DBG_Assert(data <= 0); // unsupported


DBG_Assert(data <= 1); // unsupported

manup · 2020-11-15T11:54:44Z

tuya.cpp

+            if (part > 0 && listday.size() >= static_cast<int>(part))
+            {
+                updateThermostatSchedule(sensorNode, listday.at(part - 1), transitions);
+            }


The check is good now, but updateThermostatSchedule() will never be called because due the prior for loop part will always be decremented down to 0.

I have to admit I don't understand the logic here. Is this supposed to be within the loop?

Yep, there is something not finished here #3457 (comment)
Not enought time to test it, and as I don't want to broke something, I had let the old tested version.

Have corrected the code, schedule is not the more important ATM.

Smanar added 9 commits October 16, 2020 22:13

Thermostat Essentials Premium

465c395

Update rest_sensors.cpp

f034350

Update de_web_plugin.cpp

442b9ca

Update de_web_plugin.cpp

2065fca

Avoid 30 degre for thermostat temperature

32ac2df

typo

c98e3a4

Disable lowbattery for a thermostat.

349b938

Merge branch 'tuya' into pach1

3fd3a16

Merge pull request #2 from dresden-elektronik/pach1

378545a

Update

This was linked to issues Oct 20, 2020

Moes HY368 (aka Tuya) TS0601 on 2.05.85 #3440

Closed

Tuya TS0012 switches #3424

Closed

Tuya cleaning

611d21e

This was linked to issues Nov 4, 2020

Zenismart ZigBee Smart Curtain Switch ZW-EC-01 #3438

Closed

_TYZB02_keyjqthh TS0041 #3042

Closed

Smanar linked an issue Nov 10, 2020 that may be closed by this pull request

Zemismart Chain Roller Shades Driver M515EGB (TS0601) #3348

Closed

Smanar added 3 commits November 12, 2020 17:23

Update from dev branch

de63144

Merge branch 'tuya_pr' into to_delete

16fd6d8

Merge pull request #5 from dresden-elektronik/to_delete

5769564

Update code with last official version

This was linked to issues Nov 12, 2020

Lonsonho (Tuya) X713A - _TYZB01_xiuox57i / TS0013 #3594

Closed

Thermostat Essentials Premium (Tuya) #3381

Closed

Moes Tuya Thermostat BTH-002 #3304

Closed

manup changed the title ~~Tuya improvement~~ Tuya thermostat and switch improvements, Kwikset 914 smart lock Nov 14, 2020

manup requested changes Nov 14, 2020

View reviewed changes

tuya.cpp Outdated Show resolved Hide resolved

tuya.cpp Outdated Show resolved Hide resolved

tuya.cpp Outdated Show resolved Hide resolved

tuya.cpp Outdated Show resolved Hide resolved

tuya.cpp Outdated Show resolved Hide resolved

Smanar added 2 commits November 14, 2020 18:20

Requested changes, part 1

ecf117e

Requested changes, part 2

c108fba

Smanar requested a review from manup November 14, 2020 21:08

add 4 th button

6b32bb8

manup requested changes Nov 15, 2020

View reviewed changes

@Smanar Requested changes, part 3

092461f

Smanar requested a review from manup November 15, 2020 13:42

typo

d6fd5c1

manup approved these changes Nov 15, 2020

View reviewed changes

manup merged commit 22e275b into dresden-elektronik:master Nov 15, 2020

N1co93 mentioned this pull request Jan 2, 2021

Thermostat Essentials Premium - Mode missing #4079

Closed

Tuya thermostat and switch improvements, Kwikset 914 smart lock #3457

Tuya thermostat and switch improvements, Kwikset 914 smart lock #3457

Uh oh!

Conversation

Smanar commented Oct 20, 2020 • edited by manup Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manup commented Nov 8, 2020

Uh oh!

Mimiix commented Nov 9, 2020

Uh oh!

Smanar commented Nov 9, 2020

Uh oh!

manup commented Nov 14, 2020

Uh oh!

manup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Smanar commented Oct 20, 2020 •

edited by manup

Loading