-
Notifications
You must be signed in to change notification settings - Fork 518
Add option to enable hue-mode as a deCONZ argument #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You also need to update |
Thanks for reviewing. An authenticated GET /config uses configToMap, which calls basicConfigToMap first, which sets these variables, or did I miss something? |
Ah, you moved generating these attributes to |
No worries, thanks again for checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, can you please have a look.
swupdate2["install"] = false; | ||
autoinstall["updatetime"] = ""; | ||
autoinstall["on"] = false; | ||
swupdate2["autoinstall"] = autoinstall; | ||
swupdate2["lastchange"] = ""; | ||
swupdate2["lastinstall"] = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"install" and "lastinstall" are present in the Hue API why remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Hue API documentation is not very clear on this, but from the actual bridge it looks like:
- "install" is a write only item
- "lastinstall" is only part of the swupdate2 state for the bridge subobject
rest_configuration.cpp
Outdated
{ | ||
map["swversion"] = QLatin1String("1941132070"); | ||
map["apiversion"] = QLatin1String("1.41.0"); | ||
// map["modelid"] = QLatin1String("BSB002"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Hue "modelid" was remove above it should to be set here I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"modelid" is set in line 1081 to "deCONZ", it seems that the Hue App at least doesn't care that it's not "BSB002".
I at least can remove the commented lines though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, the Hue App might be fine but have you tested this also with Amazon Echo?
If in doubt I'd vote to just keep the BSB002 modelid
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it directly with the Echo, I'm using Alexa integration through homebridge. Just to be sure I've put back the BSB002 modelid.
Hello, this feature is still working ? |
Without this command-line deconz argument option the basic config (without a user/api-key) isn't hue-compatible as the mode is normally based on the api-key. That seems to hinder initial hue-app pairing sometimes.