Repository navigation
Enhacements and improvements - #3732
Conversation
- Corrected exposure of current values - Ensure the device choses reasonable reporting thresholds
| { | ||
| if (name.size() > MAX_RULE_NAME_LENGTH) | ||
| { | ||
| rsp.list.append(errorToMap(ERR_MISSING_PARAMETER, QString("/rules/name"), QString("invalid/missing parameters in body"))); |
There was a problem hiding this comment.
Doesn't ERR_INVALID_VALUE fit in better here?
There was a problem hiding this comment.
Well, yes. Smanar also mentioned something similar. We should generally rework the API parts and make it more consistent and robust.
Was just going with the (erroneous) flow here, but happy to amend 😁
- Revert previous change in this regard - Enable sending default responses for cluster 0x0500 if requested
|
I hope to see that merged for the next stable release :) |
| rq3.maxInterval = 300; | ||
| if (sensor && (sensor->modelId() == QLatin1String("SP 120") || // innr | ||
| sensor->modelId() == QLatin1String("DoubleSocket50AU") || // Aurora | ||
| sensor->modelId().startsWith(QLatin1String("SPLZB-1")) // Develco smart plug |
| sensor->modelId() == QLatin1String("SKHMP30-I1") || // GS smart plug | ||
| sensor->modelId().startsWith(QLatin1String("SPW35Z")))) // RT-RK OBLO SPW35ZD0 smart plug | ||
| else if (sensor && (sensor->modelId() == QLatin1String("SmartPlug") || // Heiman | ||
| sensor->modelId().startsWith(QLatin1String("EMIZB-1")) // Develco EMI |
|
|
||
| // Allow clearing the alarm bit for Develco devices | ||
| if (!(zclFrame.frameControl() & deCONZ::ZclFCDisableDefaultResponse)) | ||
| { | ||
| sendZclDefaultResponse(ind, zclFrame, deCONZ::ZclSuccessStatus); | ||
| } |
There was a problem hiding this comment.
Tricky, the default response should only be send when no other response is sent.
There was a problem hiding this comment.
Hello. Not sure if this is the correct place to comment. Just saw this update and tried it out and it works great. I can stop the siren with the button on the smoke detector and the alarm bit gets cleared. I can also stop the siren from the API and the alarm bit also gets cleared there. Thank you @SwoopX for finding the solution.
| { | ||
| if (map[pi.key()].type() == QVariant::Double) | ||
| { | ||
| //if (map[pi.key()].type() == QVariant::Double) | ||
| //{ | ||
| qint16 coolsetpoint = map[pi.key()].toInt(&ok); |
There was a problem hiding this comment.
I wouldn't remove that check. If the client sends the value as string it should be fixed in the client by using a number.
The docs also describe that parameter as Number (700–3500):
https://dresden-elektronik.github.io/deconz-rest-doc/endpoints/sensors/
5 participants
Uh oh!
There was an error while loading. Please reload this page.