Skip to content

Initial support for Develco Smart Cable #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Dec 17, 2020

Second try, sorry
for #3667

@Smanar Smanar linked an issue Dec 17, 2020 that may be closed by this pull request
@Smanar Smanar changed the title Develco2 Develco Smart Cable Dec 17, 2020
@SwoopX
Copy link
Collaborator

SwoopX commented Dec 22, 2020

@Smanar with the new one, you seem to have missed some spots which were previously considered. Can you double check?

@Smanar
Copy link
Collaborator Author

Smanar commented Dec 23, 2020

Better now ?

Sorry, too much PR started and not finished ...

Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device would need an addition around L1750 in bindings.cpp to report 1V steps. Apart from the 2 comments, it should be fine. Thanks!

@Smanar Smanar requested a review from SwoopX December 24, 2020 15:02
@SwoopX
Copy link
Collaborator

SwoopX commented Dec 24, 2020

👍 That should do the trick.

@manup
Copy link
Member

manup commented Jan 12, 2021

Hi, looks like initial support for this device?
If yes can you please change the PR title and prepent "Initial support for".

@Smanar Smanar changed the title Develco Smart Cable Initial support for Develco Smart Cable Jan 12, 2021
@SwoopX SwoopX removed a link to an issue Jan 17, 2021
@manup manup added this to the v2.10.0-beta milestone Feb 4, 2021
@manup
Copy link
Member

manup commented Feb 15, 2021

Can you please sync this PR this latest master, then it's ready to merge.

@manup manup merged commit 203705d into dresden-elektronik:master Feb 15, 2021
@Smanar Smanar deleted the develco2 branch April 21, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants