-
Notifications
You must be signed in to change notification settings - Fork 518
Initial support for Develco Smart Cable #3956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Smanar with the new one, you seem to have missed some spots which were previously considered. Can you double check? |
Better now ? Sorry, too much PR started and not finished ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The device would need an addition around L1750 in bindings.cpp
to report 1V steps. Apart from the 2 comments, it should be fine. Thanks!
👍 That should do the trick. |
Hi, looks like initial support for this device? |
Can you please sync this PR this latest master, then it's ready to merge. |
Second try, sorry
for #3667