Repository navigation
Initial support for Develco Smart Cable - #3956
Merged
Merged
Conversation
Closed
Collaborator
|
@Smanar with the new one, you seem to have missed some spots which were previously considered. Can you double check? |
Collaborator
Author
|
Better now ? Sorry, too much PR started and not finished ... |
SwoopX
requested changes
Dec 23, 2020
SwoopX
left a comment
SwoopX
left a comment
Collaborator
There was a problem hiding this comment.
The device would need an addition around L1750 in bindings.cpp to report 1V steps. Apart from the 2 comments, it should be fine. Thanks!
SwoopX
approved these changes
Dec 24, 2020
Collaborator
|
👍 That should do the trick. |
Member
|
Hi, looks like initial support for this device? |
Closed
Member
|
Can you please sync this PR this latest master, then it's ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second try, sorry
for #3667