Skip to content

LIDL remote, Trådfri shortcut button #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 23, 2020
Merged

LIDL remote, Trådfri shortcut button #3975

merged 7 commits into from
Dec 23, 2020

Conversation

ebaauw
Copy link
Collaborator

@ebaauw ebaauw commented Dec 19, 2020

See #3829 and #3495.

@ebaauw ebaauw requested a review from manup December 19, 2020 23:37
@ebaauw ebaauw linked an issue Dec 19, 2020 that may be closed by this pull request
- Change `manufacturername` and `modelid` to normal values.
Use "normal" names for LIDL devices.
@ebaauw
Copy link
Collaborator Author

ebaauw commented Dec 20, 2020

With the latest commit, the following LIDL devices should have regular manufacturername and modelid values, as mentioned in the manuals. I you previously paired any of these devices, it should be enough to re-read the Basic cluster attributes, to get the proper values.

device Manufacturer Name Model Identifier manufacturername modelid
LED bulb (GU.10) _TZ3000_el5kt5im TS0502A LIDL Livarno Lux HG06492A
Remote Control _TYZB01_bngwdjsr TS1001 LIDL Livarno Lux HG06323
RGB lamp (E27) _TZ3000_dbou1ap4 TS0505A LIDL Livarno Lux HG06106C
Smart USB Extension Lead (EU) _TZ3000_1obwwnmq TS011F LIDL Silvercrest HG06338
Xmas light strip _TZE200_s8gkrkxk TS0601 _TZE200_s8gkrkxk TS0601

At the request of @Thomas-Vos, I didn't change the Xmas light strip, not to break Hue Essentials. Also, the manual doesn't mention a model ID for the light strip (only for the power adapter).

@Thomas-Vos Thomas-Vos mentioned this pull request Dec 20, 2020
- Refactor handling of LIDL (Tuya) _Manifacturer Name_, now driven by translation table.
- Add more LIDL devices, see #3981.
@ebaauw
Copy link
Collaborator Author

ebaauw commented Dec 20, 2020

Refactored the translation of Tuya-like Manufacturer Name to manufacturername and modelid. It's now based on a translation table, lidlDevices[]. Not sure if the scheme is applicable to Tuya devices as well, but this is definitely more maintainable then whitelisting the values "everywhere". Table is checked through getLidlDevice() and isLidlDevice() in addLightNode() and addSensorNode(), and in updateLightNode() and updateSensorNode(), when receiving ManifacturerName or ModelIdentifier.

static const lidlDevice lidlDevices[] = { // Sorted by zigbeeManufacturerName
{ "_TYZB01_bngwdjsr", "TS1001", "LIDL Livarno Lux", "HG06323" }, // Remote Control
{ "_TZ3000_1obwwnmq", "TS011F", "LIDL Silvercrest", "HG06338" }, // Smart USB Extension Lead (EU)
{ "_TZ3000_49qchf10", "TS0502A", "LIDL Livarno Lux", "HG06492C" }, // CT Light (E27)
{ "_TZ3000_dbou1ap4", "TS0505A", "LIDL Livarno Lux", "HG06106C" }, // RGB Light (E27)
{ "_TZ3000_el5kt5im", "TS0502A", "LIDL Livarno Lux", "HG06492B" }, // CT Light (GU10)
{ "_TZ3000_kdi2o9m6", "TS011F", "LIDL Silvercrest", "HG06337" }, // Smart plug (EU)
{ "_TZ3000_kdpxju99", "TS0505A", "LIDL Livarno Lux", "HG06106A" }, // RGB Light (GU10)
{ "_TZ3000_oborybow", "TS0502A", "LIDL Livarno Lux", "HG06492B" }, // CT Light (E14)
{ "_TZ3000_odygigth", "TS0505A", "LIDL Livarno Lux", "HG06106B" }, // RGB Light (E14)
{ "_TZ3000_riwp3k79", "TS0505A", "LIDL Livarno Lux", "HG06104A" }, // LED Light Strip
// { "_TZE200_s8gkrkxk", "TS0601", "LIDL Livarno Lux", "HG06467" }, // Smart LED String Lights (EU)
{ nullptr, nullptr, nullptr, nullptr }
};

@ebaauw ebaauw linked an issue Dec 20, 2020 that may be closed by this pull request
@ebaauw ebaauw changed the title LIDL remote LIDL remote, Trådfri shortcut button Dec 22, 2020
@ebaauw ebaauw changed the title LIDL remote LIDL remote, Trådfri shortcut button Dec 22, 2020
@manup manup merged commit 7785603 into dresden-elektronik:master Dec 23, 2020
@enjikaka
Copy link

This doens't seem to be working? I see it in the deconz VNC app, but in Phoscon it doens't find it under "Add new switch" with either IKEA or Other as vendor... deCONZ version 2.9.3 on Home Assistant

@Mimiix
Copy link
Collaborator

Mimiix commented Mar 3, 2021

@enjikaka It does work for other users so i suspect something else. Please open a new user question with logs and atleast a screen of the deCONZ vnc map.

@lukecarbis
Copy link

I have this same problem. Phoscon doesn't find it under "Add new switch" (tried adding as "other" since there was no option for the Shortcut button, only Dimmer and Remote Control). I'm also using Home Assistant, version 2.9.3.

The Shortcut button DOES show in VNC, and also in Home Assistant. After double checking, it does not show on Phoscon under Switches (or anywhere else).

Screen Shot 2021-03-04 at 15 45 31

Screen Shot 2021-03-04 at 15 51 12

@SwoopX
Copy link
Collaborator

SwoopX commented Mar 4, 2021

This is all good. Please note that deconz != Phoscon. The corresponding issue for the Phoscon repo is linked above.

@enjikaka
Copy link

enjikaka commented Mar 4, 2021

I've got the exactly same situation as @lukecarbis! I do get the buttons battery status as an entity in Home Assistant through, but nothing more. Empty in Phoscon and deCONZ VNC looks the same way, except from showing the battery too:
Skärmavbild 2021-03-04 kl  11 04 08

Wrongly though...

Skärmavbild 2021-03-04 kl  11 04 38

@Mimiix
Copy link
Collaborator

Mimiix commented Mar 4, 2021

@enjikaka @lukecarbis You should be checking deconz.event in HA.

If it's in deconz it is supported / added.

I'm locking this PR as it's finished and it's not the place to ask for support. If you have questions, feel free to open a user question issue.

@dresden-elektronik dresden-elektronik locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIDL devices (Lidl) Livarno Lux Remote Control add ikea Tradfri shortcut button support
6 participants