Various enhancements and fixes #4041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- Expose RStateValve, RConfigLocked and RConfigMode via API - Automatically configure corresponding attribute reporting
It is beneficial to also output cluster, endpoint, command and payload to better spot potential errors in the button maps.
Closed
hbkoenig
reviewed
Jan 11, 2021
de_web_plugin.cpp
Outdated
| QTime time = QTime::currentTime(); | ||
| #if QT_VERSION < 0x050000 | ||
| etag = QString(QCryptographicHash::hash(time.toString().toAscii(), QCryptographicHash::Md5).toHex()); | ||
| etag = QString(QCryptographicHash::hash(time.toString("hh:mm:ss.zzz").toAscii(), QCryptographicHash::Md5).toHex()); |
There was a problem hiding this comment.
why do you use only time for etag hash, why not ad date too ?
and why not add measurement values and/or other stuff too ?
the md5 hash is much longer than the raw time string (12 vs. 32 chars), I don't get it what here a md5 hash can be good for ?!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.