Orvibo Dry contact and ST30 sensor #4156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 10, 2021
Member
Is this empty values issue figured out yet? I think the PR shouldn't be merged before that, since most clients somehow expect these values to be present. |
Member
|
Any news here regarding the empty values? |
Collaborator
Author
|
Yes, It seem working from the user, I m asking the JSON to check value. |
Collaborator
Author
|
It s ok, the missing value are ok now. |
manup
reviewed
Mar 3, 2021
Member
manup
left a comment
manup
left a comment
There was a problem hiding this comment.
One small thing otherwise good to go.
In future we should check how to use the R_GetProductId() for Orvibo devices to improve these weird model ids in a controlled way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temperature snesor, working fine #3885
Dry contact #3973 working fine but model id and manufacture name are empty.