-
Notifications
You must be signed in to change notification settings - Fork 530
Fix Electrical Measurement cluster readings #4448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No need to filter attributes per device, if attributes aren't available they won't be read a second time, as this is checked later on. Fixes Blitzwolf BW-SHP13 ZHAPower sensor updates. Issue: dresden-elektronik#3788
|
@manup I don't remember for osram, but for legrand attributes are availables, just useless, values are locked to 0. |
|
In general, you're right. However, a couple of months ago, I added some code to just query available attributes. Hence, if the attributes are non-existant, nothing will be queried. Now with your example, I guess it all boils down to exposure of the resource items in question. E.g. the Osrams just report garbage as power, so power shouldn't be exposed for those. I suppose it should be double checked if the unwanted and previously blacklisted items aren't exposed via API... |
I could only check for OSRAM plug, here the RMS attributes are not available. The add sensor node code doesn't add these items to Legrand devices either, I think they should be fine too? |
|
Is it released? |
|
@marithpl Yes. Did you create a issue already? |
|
I've reopened #3788 |
No need to filter attributes per device, if attributes aren't available they won't be read a second time, as this is checked later on.
Fixes Blitzwolf BW-SHP13 ZHAPower sensor updates.
Issue: #3788