Skip to content

Conversation

@manup
Copy link
Member

@manup manup commented Feb 19, 2021

No need to filter attributes per device, if attributes aren't available they won't be read a second time, as this is checked later on.

Fixes Blitzwolf BW-SHP13 ZHAPower sensor updates.
Issue: #3788

No need to filter attributes per device, if attributes aren't available they won't be read a second time, as this is checked later on.

Fixes Blitzwolf BW-SHP13 ZHAPower sensor updates.
Issue: dresden-elektronik#3788
@manup manup added this to the v2.10.1-beta milestone Feb 19, 2021
@Smanar
Copy link
Collaborator

Smanar commented Feb 19, 2021

@manup I don't remember for osram, but for legrand attributes are availables, just useless, values are locked to 0.
And from my memory it s same for Osram, the value is locked to 50 or something like that.

@SwoopX
Copy link
Collaborator

SwoopX commented Feb 20, 2021

In general, you're right. However, a couple of months ago, I added some code to just query available attributes. Hence, if the attributes are non-existant, nothing will be queried.

Now with your example, I guess it all boils down to exposure of the resource items in question. E.g. the Osrams just report garbage as power, so power shouldn't be exposed for those. I suppose it should be double checked if the unwanted and previously blacklisted items aren't exposed via API...

@manup
Copy link
Member Author

manup commented Feb 22, 2021

@manup I don't remember for osram, but for legrand attributes are availables, just useless, values are locked to 0.
And from my memory it s same for Osram, the value is locked to 50 or something like that.

I could only check for OSRAM plug, here the RMS attributes are not available.
But more importantly, the plug doesn't have the RStateVoltage and RStateCurrent ResourceItems so they won't be set to bogus values.

The add sensor node code doesn't add these items to Legrand devices either, I think they should be fine too?

@manup manup merged commit 2e9a2b0 into dresden-elektronik:master Feb 22, 2021
@manup manup linked an issue Feb 22, 2021 that may be closed by this pull request
@marithpl
Copy link

Is it released?
I have still problem with SHP13 and power consumption.

@Mimiix
Copy link
Collaborator

Mimiix commented Mar 23, 2021

@marithpl Yes. Did you create a issue already?

@marithpl
Copy link

I didn't.
I found a bug report #3788 with same issue.
Here is my issue: #4629

@Mimiix
Copy link
Collaborator

Mimiix commented Mar 23, 2021

I've reopened #3788

@manup manup deleted the fix_power_readings branch May 6, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HEIMAN BW-SHP13 look a like is not showing powerconsumption

5 participants