Make Regulation SetPoint Offset usable as offset for Danfoss Ally - #4881
Merged
Merged
Conversation
Includes some further minor enhancements
manup
reviewed
May 22, 2021
manup
left a comment
manup
left a comment
Member
There was a problem hiding this comment.
👍 for using more QLatin1String :)
PR looks fine function wise, added some small style comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows setting the manufacturer specific attribute 0x404B (Regulation SetPoint Offset) via the offset resource item exposed through REST API. It has an allowed range of +-2.5° C. Using it will basically make the thermostat over-/underheat accoding to the set value, thereby automatically adjusting the set heat setpoint.
Includes some further minor enhancements.