Fix: Emit button event 1002 again for TRADFRI remote control after mode switch - #4951
Merged
Conversation
SwoopX
changed the title
SwoopX
changed the title
|
Could you please fix a typo related to this PR in the changelogs? Both English and German changelogs list this fix as #5951 instead of #4951 which gives 404 instead of the proper thing. Thanks! |
Collaborator
Author
|
Pinged @manup |
Member
|
Thanks for the hint, link is corrected now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pushing the on/off button of the switch approx. 5 seconds, the device changes the operational mode so that the arrow buttons do not send any commands on hold/long press. Under certain conditions (apparently when the arrow keys haven't been used before), this can lead to button event 1002 not being emitted, although the corresponding command is send.
As the respective code was intended for the STYRBAR remote, it is now restricted to that device.