Add support for Aqara Wireless Remote Switch H1 (Double Rocker) WRS-R02 #5067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manup
reviewed
Jul 5, 2021
Member
manup
left a comment
manup
left a comment
There was a problem hiding this comment.
Some smaller questions in the comments.
The PR description should also mention that the multi-click attribute 0x0125 is configured for "86opcn01" (human readable switch name? ;) as well.
de_web_plugin.cpp
Outdated
Comment on lines
16376
to
16382
| writeAttribute(sensor, 0x01, XIAOMI_CLUSTER_ID, attr, VENDOR_XIAOMI); | ||
|
|
||
| // Activate multiclick mode | ||
| DBG_Printf(DBG_INFO, "Write Aqara switch 0x%016llX multiclick mode attribute 0x0125 = 2\n", sensor->address().ext()); | ||
| deCONZ::ZclAttribute attr2(0x0125, deCONZ::Zcl8BitUint, QLatin1String("multiclick mode"), deCONZ::ZclReadWrite, false); | ||
| attr2.setValue(static_cast<quint64>(2)); | ||
| writeAttribute(sensor, 0x01, XIAOMI_CLUSTER_ID, attr2, VENDOR_XIAOMI); |
Member
There was a problem hiding this comment.
Is it safe to assume hard coded endpoint 0x01 here for "86opcn01" and "b28ac1", or is the formerly used sensor->fingerPrint().endpoint a better fit?
Collaborator
Author
There was a problem hiding this comment.
Yes, endpoint 0x01 should be save. I guess I can amend that.
The corresponding switch sensors should have been manually pinned to endpoint 1, so using `sensor->fingerPrint().endpoint` should be fine
manup
added a commit
to manup/deconz-rest-plugin
that referenced
this pull request
Jul 15, 2021
Regression from v2.12.2-beta. Due the duplicated JSON key "xiaomiSwitchB1acn01Map", only the last one was properly loaded. Related PR: dresden-elektronik#5067 Issue: dresden-elektronik#5117
manup
added a commit
to manup/deconz-rest-plugin
that referenced
this pull request
Jul 15, 2021
Regression from v2.12.2-beta. Due the duplicated JSON key "xiaomiSwitchB1acn01Map", only the last one was properly loaded. Related PR: dresden-elektronik#5067 Issue: dresden-elektronik#5117 Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4842.
This PR also adds writing the multi-click attribute
0x0125for Aqara Opple switches (lumi.remote.b686opcn01, lumi.remote.b486opcn01 and lumi.remote.b286opcn01).