Fix: Make Xiaomi WRS-R02 switch configuration more robust #5136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there's always one more place to whitelist, the device now adds `RConfigPending` after restart to allow switch configuration. Additionally, to make the configuration procedure more robust, `RConfigPending` is now set to require configuration upon device announcement (currently applicable for Opples and WRS-R02). This ensures the Xiaomi device operation mode is marked for writing when the device is reset AND a ZHASwitch resource already exists which is not marked as deleted. Without it, the device does not get configured if reset more than once while deconz is running.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there's always one more place to whitelist, the device now adds
RConfigPendingafter restart to allow switch configuration.Additionally, to make the configuration procedure more robust,
RConfigPendingis now set to require configuration upon device announcement (currently applicable for Opples and WRS-R02). This ensures the Xiaomi device operation mode is marked for writing when the device is reset AND a ZHASwitch resource already exists which is not marked as deleted. Without it, the device does not get configured if reset more than once while deconz is running.