Add DDF for Danfoss Ally thermostat - #5793
Merged
Merged
Conversation
Collaborator
|
Why the status is still draft ? |
Collaborator
Author
|
That's relatively simple, because
😄 Other than that, the DDF works. |
SwoopX
marked this pull request as ready for review
March 23, 2022 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on #5857
DDF including default parsing functions for
scheduler_on,heatsetpoint,valve,locked,lastset,localtimeandutcresource items. Furthermore, device specific code has been partially removed. Mostconfig/resource items now use state changes to write data on the device anddevManagedcheck has been extended to power configuration, thermostat UI and diagnostics cluster. Lastly, as an interim solution, the to check for time drifts on the time cluster had to be moved fromupdateSensorNode()tohandleTimeClusterIndication(), as otherwise a time sync wouldn't be triggered anymore on managed devices.It should also be applicable for POPP and Hive thermostat if manufacturer name and model ID are changed accordingly