Add DDF for Xiaomi H1 dual rocker switch (neutral wire) WS-EUK04 - #5893
Merged
Merged
Conversation
SwoopX
marked this pull request as ready for review
March 21, 2022 08:32
SwoopX
changed the title
Member
|
Looks good to me, but needs to be realigned on latest master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on #5857
Adds the DDF and removes the respective legacy code. For the created ZHASwitch resource,
config/devicemodeis added to automatically put the device in the required mode of operation. Furthermore,config/ledindicationis added to ZHASwitch resource to be able to disable the LEDs during night time. Both is set on the first endpoint only, so the switch resource can be chosen to make the resource items available.What's still to be clarified is setting the decoupled mode. As this is set per endpoint (there's 2), the light resources would probably make sense. However, they do not really support
configresource items.