Skip to content

Conversation

@manup
Copy link
Member

@manup manup commented Apr 26, 2022

  • In legacy delayedFastEnddeviceProbe() function don't interfere with Device code ZDP requests for Node Descriptor, Active Endpoints and Simple Descriptors.
  • Consider already available data in Basic cluster attributes during pairing, which is needed for some Xiaomi sensors that send the modelid in a report.
  • Fix handling of unsupported binding table status (Xiaomi sensors send a response which has only 2 bytes of payload).
  • Check if there is polling needed after awake event, that's useful during pairing to quickly query all needed attributes.
  • Sync NWK address changes from core to device attr/nwkaddress resource item.

Related issue #5974

@SwoopX
Copy link
Collaborator

SwoopX commented Apr 27, 2022

Nice one. Would it also make sense to prevent the request towards the basic cluster in delayedFastEnddeviceProbe() a bit further down? I'd assume that is managed by the DDF code as well.

@manup manup added this to the v2.15.3 milestone Apr 28, 2022
@manup
Copy link
Member Author

manup commented Apr 28, 2022

Yes it makes sense to limit processing further :) Currently only the first steps of joining are considered to not accidently break anything. Before merging I'll add a small bit on top to bail out as soon as we know the device is controlled by a DDF (likely only Gold status for now).

In the sniffer joining now looks less noisy, the Xiaomi humidity sensor was a hit and miss to join since it didn't poll so often.

manup added 5 commits April 29, 2022 17:39
Needed for some Xiaomi sensors which send modelid in a report.
Xiaomi sensors send a response which has only 2 bytes of payload.
Useful also during pairing to quickly query all needed attributes
If a device changes its NWK address this need to be synced from core to the device resource item.
@manup manup force-pushed the dev_improvements branch from d1a7296 to c2159ff Compare April 29, 2022 19:54
@manup manup merged commit 7d13553 into dresden-elektronik:master Apr 29, 2022
@manup manup deleted the dev_improvements branch January 3, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants