-
Notifications
You must be signed in to change notification settings - Fork 528
DDF add manufacturer name "frient A/S" for keypad KEPZB-110 #6154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some people might have the other version with the other manufacturer name. @manup can't 2 manufacturer names be used? |
Idaho947
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you ask I hope in order to add two manufactername and modelid
|
The file edition haven't worked ^^. The DDF will work for both device "Develco Products A/S"-"KEPZB-110" AND "frient A/S"-"KEPZB-110" On your actual modification you disable the DDF for user with the "Develco Products A/S" |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "schema":"devcap1.schema.json", | |||
| "manufacturername":"Develco Products A/S", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"manufacturername": ["Develco Products A/S", "frient A/S"],
devices/frient/kepzb-110_keypad.json
Outdated
| "schema":"devcap1.schema.json", | ||
| "manufacturername":"Develco Products A/S", | ||
| "manufacturername":"frient A/S", | ||
| "modelid":"KEPZB-110", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"modelid": ["KEPZB-110", "KEPZB-110"],
|
I try to review but I'm not of what I'm doing... |
|
Easier. |
|
Ok done thanks |
|
Info: The PR is merged in dacfc6f, but somehow GitHub doesn't show it as such. |
If frient is not mention it doesn't work why this keypad.