Skip to content

Conversation

@Idaho947
Copy link
Contributor

If frient is not mention it doesn't work why this keypad.

@Mimiix
Copy link
Collaborator

Mimiix commented Jun 29, 2022

Some people might have the other version with the other manufacturer name. @manup can't 2 manufacturer names be used?

@Smanar
Copy link
Collaborator

Smanar commented Jun 29, 2022

@Mimiix yes it's possible.

@Idaho947 pls can you edit your code like that

"manufacturername": ["Develco Products A/S", "frient A/S"],
"modelid": ["KEPZB-110", "KEPZB-110"],

Copy link
Contributor Author

@Idaho947 Idaho947 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you ask I hope in order to add two manufactername and modelid

@Smanar
Copy link
Collaborator

Smanar commented Jun 30, 2022

The file edition haven't worked ^^.
But yes if you write

"manufacturername": ["Develco Products A/S", "frient A/S"],
"modelid": ["KEPZB-110", "KEPZB-110"],

The DDF will work for both device "Develco Products A/S"-"KEPZB-110" AND "frient A/S"-"KEPZB-110"

On your actual modification you disable the DDF for user with the "Develco Products A/S"

@@ -1,6 +1,6 @@
{
"schema":"devcap1.schema.json",
"manufacturername":"Develco Products A/S",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"manufacturername": ["Develco Products A/S", "frient A/S"],

"schema":"devcap1.schema.json",
"manufacturername":"Develco Products A/S",
"manufacturername":"frient A/S",
"modelid":"KEPZB-110",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"modelid": ["KEPZB-110", "KEPZB-110"],

@Idaho947
Copy link
Contributor Author

I try to review but I'm not of what I'm doing...

@Smanar
Copy link
Collaborator

Smanar commented Jun 30, 2022

Easier.
Just edit (again) the file on your fork https://github.com/Idaho947/deconz-rest-plugin/tree/patch-1/devices/frient
The PR will be updated itself.

@Idaho947
Copy link
Contributor Author

Ok done thanks

@Smanar Smanar changed the title Update kepzb-110_keypad.json Fix : Add a variant for the kepzb-110 keypad Jun 30, 2022
@manup manup added this to the v2.17.1 milestone Jun 30, 2022
@manup manup changed the title Fix : Add a variant for the kepzb-110 keypad DDF add manufacturer name "frient A/S" for keypad KEPZB-110 Jul 1, 2022
@manup
Copy link
Member

manup commented Jul 1, 2022

Info: The PR is merged in dacfc6f, but somehow GitHub doesn't show it as such.

@manup manup merged commit dacfc6f into dresden-elektronik:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants