Skip to content

Fixed consumption reporting for Sengled E1C-NB7 - #6172

Merged
manup merged 2 commits into
dresden-elektronik:masterfrom
kimmeld:master
Jul 6, 2022
Merged

manup merged 2 commits into
dresden-elektronik:masterfrom
kimmeld:master

Conversation

@kimmeld

@kimmeld kimmeld commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

This fixes Issue #6099

@SwoopX SwoopX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments to give the device the last finish 🙂

Comment thread devices/sengled/e1c-nb7.json Outdated
Comment thread devices/sengled/e1c-nb7.json Outdated
Comment thread devices/sengled/e1c-nb7.json Outdated
@kimmeld

kimmeld commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

I've made the required changes, hopefully this is good now 🙂

@SwoopX SwoopX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@SwoopX SwoopX added this to the v2.18.0-beta milestone Jul 5, 2022
@manup
manup merged commit 1a4811c into dresden-elektronik:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants