-
Notifications
You must be signed in to change notification settings - Fork 520
Add further Danfoss specific resource items #6175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This would be really useful to have. |
Shouldn’t the |
Yeah, I guess so. Not sure if you had a reason to do it as is back in the days? 🙂 |
these changes will be available when in the latest version ? |
What is blocking for this PR ? |
I would really appreciate these items to be available soon. |
I would really appreciate it if we could add the items discussed in as well #6872. This will help distribute the load between the radiators which is helpfull when you have multiple radiators of different sizes in the same room. |
Almost ready, can you please also change the remaining |
That now took me a while to understand which ones you meant as I was focussed on Danfoss and totally forgot about the additions 😀 Done |
May a little late, but I just saw that the PR was merged now. |
I think the better solution is making a new PR just for them, it's not possible (more complex) to rollback a PR just for that. |
This PR adds a few missing resource item json files:
config/lastchange_source
config/lastchange_time
config/lastchange_amount
and adds a few new resource items for thermostats (primarily Danfoss specific):
config/mode
-> Generic item, allowing for values 'off' and 'heat'. Set to 'off' when heating period ends to prevent unnecessary valve adjustments.config/loadbalancing
-> Thermostat runs stand alone (false) or shares load with others in the same room (true).config/radiatorcovered
-> Radiator is standing freely (false) or is covered (true). Set this to true for Danfoss Ally to use external temp sensor.config/windowopendetectionenabled
-> Turns the window open detection feature on or off.