Skip to content

Update FW version string for Mijia Light Sensor GZCGQ01LM#6217

Merged
manup merged 5 commits intodresden-elektronik:masterfrom
SwoopX:xiaomilightsensor
Jul 31, 2022
Merged

Update FW version string for Mijia Light Sensor GZCGQ01LM#6217
manup merged 5 commits intodresden-elektronik:masterfrom
SwoopX:xiaomilightsensor

Conversation

@SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Jul 24, 2022

  • Updates the FW version string
  • Removes legacy device code

@SwoopX SwoopX added this to the v2.18.0-beta milestone Jul 24, 2022
@manup
Copy link
Member

manup commented Jul 30, 2022

Can you please rebase on latest master, GIT complains about conflicts due the other merged PRs.

@SwoopX
Copy link
Collaborator Author

SwoopX commented Jul 31, 2022

@manup done

@manup
Copy link
Member

manup commented Jul 31, 2022

Looks like there is a missing comma in line 70?
And one too much after the parse object in line 77.

image

cat xiaomi/xiaomi_gzcgq01lm_light_sensor.json | jq
parse error: Expected separator between values at line 70, column 17

Note to myself, we need a GitHub action to validate JSON files :)

@manup manup merged commit d0d26ba into dresden-elektronik:master Jul 31, 2022
@SwoopX
Copy link
Collaborator Author

SwoopX commented Jul 31, 2022

Yeah, should indeed be validated 🙂

@SwoopX SwoopX deleted the xiaomilightsensor branch October 30, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants