Skip to content

DDF for Terncy Smart Dial SD01 - #6218

Merged
manup merged 3 commits into
dresden-elektronik:masterfrom
SwoopX:terncyds01
Jan 18, 2023
Merged

DDF for Terncy Smart Dial SD01#6218
manup merged 3 commits into
dresden-elektronik:masterfrom
SwoopX:terncyds01

Conversation

@SwoopX

@SwoopX SwoopX commented Jul 24, 2022

Copy link
Copy Markdown
Collaborator

Adds respective DDF and removes legacy code.

Note that newly added devices require a device firmware update in order to work properly.

@manup

manup commented Jan 16, 2023

Copy link
Copy Markdown
Member

Ouh this one sits here for a while ;) from my side the PR looks all right. Should be merged in v2.21.0-beta?

Note that newly added devices require a device firmware update in order to work properly.

Did the older version work with the C++ code variant, breaking change?

@SwoopX

SwoopX commented Jan 17, 2023

Copy link
Copy Markdown
Collaborator Author

Yup, that one is sitting tight :) More than happy to get that one off the road.

It is indeed some sort of breaking change. With an old firmware, the device doesn't have a manufacturer name at all, so we have/had a hack for that in the legacy code. The new firmware corrects that and as I have the device here, I know it works. Nevertheless, it should be mentioned explicitly in the release notes (note that there's also a respective md file).

@manup

manup commented Jan 18, 2023

Copy link
Copy Markdown
Member

Ok, yeah I guess it's better to take the OTA update route and describe it as a breaking change than to carry around the hack.

I've added a new "Breaking Change" label which can be assigned to PRs, the changelog generator needs a little update and then is able to put it in the right section.

@manup manup changed the title Add DDF for Terncy Smart Dial SD01 DDF for Terncy Smart Dial SD01 Jan 18, 2023
@manup
manup merged commit 9ed6946 into dresden-elektronik:master Jan 18, 2023
@SwoopX
SwoopX deleted the terncyds01 branch August 5, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants