Fix daylight sensor configuration#6240
Merged
manup merged 1 commit intodresden-elektronik:masterfrom Aug 3, 2022
Merged
Conversation
Fix creating the lat/long items on first deCONZ start. Prior this was at least fixed by database code in next deCONZ start. Fix in case the discovery server isn't used or provides invalid coordinates the `config/configured` was never set to true, when the coordinates where set via REST-API. Fix REST-API PUT sensor/config check for valid data (coordinate as string) for lat/long and provide proper error message. Refactored the code to check and update daylight sensor uniqueid, configured items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix creating the lat/long items on first deCONZ start.
Prior this was at least fixed by database code in next deCONZ start.
Fix in case the discovery server isn't used or provides invalid coordinates the
config/configuredwas never set to true, when the coordinates where set via REST-API.Fix REST-API
PUT sensor/<id>/configto check for valid lat/long values (coordinate as string) and provide proper error message.Refactored the code to check and update daylight sensor
attr/uniqueidandconfig/configureditems.