Remove rescaling of consumption in Develco/friend ZHEMI101 DDF #6402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the division by 1000 when extracting the consumption value for the Develco/friend external meter interface ZHEMI101. This sensor comes in different flavors that is compatible with different standards. For example the EU version is compatible with the EU standard of 1000 pulses per kWh, so the value is already correct from the sensor.
|
any news on this - when do we see a new update ? |
SwoopX
approved these changes
Oct 14, 2022
Contributor
Author
|
This is my first PR and I am a bit unsure of the workflow. Do I need to mark it as done or something? 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the division by 1000 when extracting the consumption value for the Develco/friend external meter interface ZHEMI101. This sensor comes in different flavors that are compatible with different standards. For example the EU version is compatible with the EU standard of 1000 pulses per kWh, so the value is already correct from the sensor.