Fix flooding the network with ZGP broadcasts#6482
Merged
manup merged 1 commit intodresden-elektronik:masterfrom Oct 31, 2022
Merged
Fix flooding the network with ZGP broadcasts#6482manup merged 1 commit intodresden-elektronik:masterfrom
manup merged 1 commit intodresden-elektronik:masterfrom
Conversation
In a network with multiple ZGP devices (FoH switch,..) the ZGP proxy keep alive broadcast could have been send in the while loop without taking a break after each broadcast. The fix adds a minimum delay of one second (idle timer delay) between each broadcast.
Collaborator
|
Brought the changes over (all two lines ;-), compiled them and now running in my large production network. It's the only one (currently) with ZGP switches. |
Collaborator
|
Looking good, checking the deCONZ log: only one ZGP broadcast per ~8 minutes instead of a dozen at the same time, and no more 0xD2 errors. As far as I can tell, my ZGP switches still work. |
Member
Author
|
Nice fingers crossed it stays that way. The idle timer interval should be a natural guard for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a network with multiple ZGP devices (FoH switch,..) the ZGP proxy keep alive broadcast could have been send in the while loop without taking a break after each broadcast.
The fix adds a minimum delay of one second (idle timer delay) between each broadcast.