Add DDF for ZY-M100 human breathing presence sensor

[BabaIsYou]

All is described in issue #6517

[SwoopX]

Thanks for submitting the PR. Apart from the already given comments, I have to say I got mixed feelings on the usage/recycling of quite some resource items. This is pretty much stretched out for this device, e.g. sensitivitymax is not even supposed to be writable.

@manup What's your opinion here?

[BabaIsYou]

, e.g. sensitivitymax is not even supposed to be writable.

I discoverd it later because sensitivitymax is marked as writeable in devices/generic/items/config_sensitivitymax_item.json but write is not permitted in code (!?). We're working on another workaround in the initial issue, then I remove this item. Eventually a new PR will come later.

[BabaIsYou]

Modified following remarks on submitted PR

[manup]

Thanks for submitting the PR. Apart from the already given comments, I have to say I got mixed feelings on the usage/recycling of quite some resource items. This is pretty much stretched out for this device, e.g. sensitivitymax is not even supposed to be writable.

@manup What's your opinion here?

Indeed for sensitivitymax I'd also vote to keep it as a read only item. The actual write counterpart would be sensitivity.

[BabaIsYou]

Thanks for submitting the PR. Apart from the already given comments, I have to say I got mixed feelings on the usage/recycling of quite some resource items. This is pretty much stretched out for this device, e.g. sensitivitymax is not even supposed to be writable.
@manup What's your opinion here?

Indeed for sensitivitymax I'd also vote to keep it as a read only item. The actual write counterpart would be sensitivity.

Then the json supporting sensistivitymax need to be updated to R instead of RW ?

[manup]

Then the json supporting sensistivitymax need to be updated to R instead of RW?

git gui blame -- devices/generic/items/config_sensitivitymax_item.json

shows that it's still my initial commit, so should hopefully be safe to set it to R.

[mprajsler]

Hi, if lux_to_lightlevel.js is used as proposed by SwoopX we need default values here
config/tholddark = 12000
config/tholdoffset = 7000
proposed values found from other light sensors

[Smanar]

Ha yes can add in DDF

        {
          "name": "config/tholddark",
          "default": 12000
        },
        {
          "name": "config/tholdoffset",
          "default": 7000
        },

So with that "state/dark" and "name": "state/daylight" will be updated too.

[SwoopX]

@mprajsler Good catch on the threshold values, I apparently missed to copy them. So it would be sufficient to just add them. Default values are already part of the definition file, no need to add it

[BabaIsYou]

@mprajsler Good catch on the threshold values, I apparently missed to copy them. So it would be sufficient to just add them. Default values are already part of the definition file, no need to add it

Done ! ;-)

[BabaIsYou]

so should hopefully be safe to set it to R.

Done thru PR #6653

[manup]

Is the PR ready to merge? :)

[BabaIsYou]

Is the PR ready to merge? :)

Yes it is ;-)
Thx