Update ZY-M100 DDF (fix & adding precision - breaking change for triggerdistance) - #6708
Merged
Merged
Conversation
Adding precision on Far detection sensitivity configuration and fixing conversion on errorcode reporting.
Member
|
This looks like a breaking change, I think the item values should use some generic approach which works for all sensors of this kind? |
Contributor
Author
|
A breaking change tested by people that asked for integration of this device less than a month ago seems not a so big deal 🤣… but you’re right and the better way to have such a generic approach would be to create a new attribute for that purpose from my point of vue. |
BabaIsYou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding precision on Far detection sensitivity configuration and fixing conversion on errorcode reporting (see #6517 )