DDF for HZC S900W-ZG water leak sensor #6832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice and easy ! ;-) Just a few comments :
About your question for tampered, not exposed by this device, could be deleted. |
|
Thanks for the suggestions :). Seems very reasonable. |
What a bunch of good questions ;-) |
agramner
force-pushed
the
ddf-hcz-s900w-zg-water-leak-sensor
branch
from
05c5d23 to
3217c35
Compare
|
Thanks, pushed your suggested changes |
ebaauw
added a commit
that referenced
this pull request
Sep 16, 2023
* Update general.xml Additional clusters for IKEA Vindstyrka, see #6756. * Update device_access_fn.cpp Fix `numtostr` and add debug log message. * Create vindstyrka_air_quality_sensor.json See #6756. * Update device_access_fn.cpp Typo in comment. * IKEA Symfonisk Sound Remote gen2 See #6775 * Update button_maps.json Validator nonsense. * Update button_maps.json More validator nonsense * Update button_maps.json And even more validator nonsense * Update button_maps.json And even more validation nonsense * Validation blues. * Bug fix: SYMFONISK support broken See #6803. * Revert "Bug fix: SYMFONISK support broken" This reverts commit af37958. * Update general.xml Remove workaround for GUI bug #6832. Fix indentation. * Update general.xml Refine definitions of: - _Hue Capabilities_ command in _Basic_ cluster; - _Hue Button_ cluster. * Reformat generic JSON files - Indent of two spaces; - Line termination using CR. * Reformat `ikea` JSON files - Indent of two spaces; - Line termination using CR. * Update light_zb3_C.json Reformat * Fix eslint warnings * Use `let` instead of `var` duktape doesn't support `let`, but loader translates it to `var`.
ebaauw
added a commit
that referenced
this pull request
Sep 16, 2023
* Update general.xml Additional clusters for IKEA Vindstyrka, see #6756. * Update device_access_fn.cpp Fix `numtostr` and add debug log message. * Create vindstyrka_air_quality_sensor.json See #6756. * Update device_access_fn.cpp Typo in comment. * IKEA Symfonisk Sound Remote gen2 See #6775 * Update button_maps.json Validator nonsense. * Update button_maps.json More validator nonsense * Update button_maps.json And even more validator nonsense * Update button_maps.json And even more validation nonsense * Validation blues. * Bug fix: SYMFONISK support broken See #6803. * Revert "Bug fix: SYMFONISK support broken" This reverts commit af37958. * Update general.xml Remove workaround for GUI bug #6832. Fix indentation. * Update general.xml Refine definitions of: - _Hue Capabilities_ command in _Basic_ cluster; - _Hue Button_ cluster. * Update resource.cpp Bump `state/eventduration` to 32-bit unsigned integer. * Update state_eventduration_item.json Bump `state/eventduration` to 32-bit unsigned integer. Dunno why it said "not implemented yet"; the Hue dimmer switch family has been using it for a long time. * Update general.xml FC06 cluster for Hue secure contact sensor. * Create soc001_contact_sensor.json * Reformat generic JSON files - Indent of two spaces; - Line termination using CR. * Reformat `ikea` JSON files - Indent of two spaces; - Line termination using CR. * Update light_zb3_C.json Reformat * Fix eslint warnings * Use `let` instead of `var` duktape doesn't support `let`, but loader translates it to `var`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied DDF from bosch water leak sensor and modified for this sensor.
These entities popped up in Home Assistant for the sensor (after a restart of HA):
Confirmed that
binary_sensor.water_xworksHaven't confirmed the rest of the sensors.
sensor.water_x_batteryis still 100% so can't be sure it works.Not sure if
tamperedis relevant for this sensor. How could that trigger?fixes #6831