Skip to content

DDF for various Tuya TRVs#6859

Merged
manup merged 3 commits intodresden-elektronik:masterfrom
Smanar:trv_8
May 23, 2023
Merged

DDF for various Tuya TRVs#6859
manup merged 3 commits intodresden-elektronik:masterfrom
Smanar:trv_8

Conversation

@Smanar
Copy link
Collaborator

@Smanar Smanar commented Apr 4, 2023

See #6856

  • Product name: Hama Smart Radiator Thermostat
  • Manufacturer: _TZE200_h4cgnbzg
  • Model identifier: TS0601

and clones

"manufacturername": ["_TZE200_h4cgnbzg", "_TZE200_exfrnlow", "_TZE200_9m4kmbfu", "_TZE200_3yp57tby", "_TZE200_9gvruqf5", "_TZE200_zr9c0day", "_TZE200_0dvm9mva"],

@Smanar Smanar mentioned this pull request Apr 4, 2023
@Smanar Smanar linked an issue Apr 4, 2023 that may be closed by this pull request
@DerOetzi
Copy link
Contributor

Can you recheck my already merged PR, which I did some weeks ago to get the TRV work: #6690 is this still neccassary with your change or should it be reverted?

@Smanar
Copy link
Collaborator Author

Smanar commented Apr 20, 2023

Can keep both.
With your code change, some device will be able to work with legacy code.
Other will work with DDF, the previous user have issue with the legacy code because a new manufacture number if I m right.
There is so much clones all can't work with legacy code.

If the DDF is good, the change will be invisible for you, even with DDF enabled.

@cagnulein
Copy link
Contributor

is this somehow releated to #6269 ?

@Smanar
Copy link
Collaborator Author

Smanar commented May 4, 2023

About "_TZE200_2ekuz3dz" ?

This DDF is for ["_TZE200_h4cgnbzg", "_TZE200_exfrnlow", "_TZE200_9m4kmbfu", "_TZE200_3yp57tby", "_TZE200_9gvruqf5", "_TZE200_zr9c0day", "_TZE200_0dvm9mva"],

Haven't checked others.

@manup
Copy link
Member

manup commented May 21, 2023

The "manufacturername" and "modelid" arrays seem to be of different lengths? Otherwise the PR looks fine.

@manup manup added this to the v2.22.1-beta milestone May 21, 2023
@Smanar
Copy link
Collaborator Author

Smanar commented May 22, 2023

Right, have corrected.

@manup manup changed the title DDF add support for some Tuya TRV DDF for various Tuya TRVs May 23, 2023
@manup manup merged commit a6d8389 into dresden-elektronik:master May 23, 2023
@Smanar Smanar deleted the trv_8 branch December 22, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hama TRV

4 participants