Skip to content

Conversation

@Carl-mgb66
Copy link
Contributor

@Carl-mgb66 Carl-mgb66 commented Apr 11, 2023

Add JSON and associated JS files to enable support of Computime/Salus PS600 Pipe Temperature Sensor

Fix #6871

Added JSON for ss909zb
Add Computime battery JS file
@SwoopX
Copy link
Collaborator

SwoopX commented Apr 16, 2023

A few questions around this:

  • Some items have "awake": true. Has it been tested that the device is really awake when anything for the respective items is received?
  • The device hold the IAS Zone cluster, does it make sense/is it necessary to enroll it. That would also involve adding 1 or 2 additional items.

@Carl-mgb66
Copy link
Contributor Author

In response to the questions, please note @BabaIsYou helped to write the files, hence I'm mentioning them here.

  1. "awake": true - please advise how I could test this and provide the feedback?
  2. IAS Zone Cluster - don't believe it is necessary to enroll it, it's working without and it doesn't really make much sense either.

Hope that helps.

@manup
Copy link
Member

manup commented Apr 17, 2023

The awake is a bit tricky to get right. It should be set to true, if the respective command in the "parse" function is followed by a MAC Data Request, unfortunately this can be seen only with a sniffer. Sometimes also with logging but only if the device has the coordinator as parent.

@Carl-mgb66
Copy link
Contributor Author

Thanks for the explanation, however I don't think I'll be able to make these checks myself. The sensor is operating reliably.

@BabaIsYou
Copy link
Contributor

  • "awake": true - please advise how I could test this and provide the feedback?

Hi @Carl-mgb66, I suggest to remove all the "awake": true, it won't change anything for that kind of device IMO.

  • IAS Zone Cluster - don't believe it is necessary to enroll it, it's working without and it doesn't really make much sense either.

Agree with that.

Removed unproven "awake": true statements
@Carl-mgb66
Copy link
Contributor Author

I've removed the "awake": true statements as suggested.

@manup manup changed the title Add Salus PS600 Pipe Temperature Sensor DDF for Salus PS600 Pipe temperature sensor Apr 19, 2023
@manup manup added this to the v2.22.0-beta milestone Apr 19, 2023
@manup manup merged commit 8996fae into dresden-elektronik:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Salus PS600 Pipe Temperature Sensor

4 participants